Messages in this thread | | | Date | Tue, 1 Nov 2011 14:57:10 -0700 | From | Tejun Heo <> | Subject | Re: [RFC PATCH] freezer: revert 27920651fe "PM / Freezer: Make fake_signal_wake_up() wake TASK_KILLABLE tasks too" |
| |
Hey, Oleg.
On Tue, Nov 01, 2011 at 08:46:01PM +0100, Oleg Nesterov wrote: > On 11/01, Oleg Nesterov wrote: > > > > Or we can add TASK_FREEZABLE (like TASK_WAKEKILL), iirc we already > > discussed this some time ago. And probably it makes sense to add the > > generic wait_event_state(). > > Forgot to mention. I think that before anything else we need > signal_wake_up_state(). For example, note that none of the callers > of signal_wake_up(resume => true) in ptrace code wants to wake up > the killable task.
Yeah, agreed for both wait_event_state() and signal_wake_up_state(). For now, let's go with the count/dont_count. Can you please write up a patch for that? Jeff, does this seem okay to you?
For TASK_FREEZABLE, I'm not entirely sure. Combined with wait_event_state(), it can definitely reduce the number of different variants of wait_event_*(). Let's see.
Thanks.
-- tejun
| |