Messages in this thread | | | From | Stephen Warren <> | Date | Tue, 1 Nov 2011 09:55:59 -0700 | Subject | RE: [PATCH] ASoc : Tegra : Add audio map for Asymptote |
| |
Taylor Hutt wrote at Tuesday, November 01, 2011 10:33 AM: > Details > > Add pin connections and audio map for the Asymptote board. > > Testing > > Visual inspection with Chromium OS 2.6.38 code. > Built kernel > Built chromium os image > Booted image on asymptote > Booted image on kaen
Presumably all that testing was within the chromeos-3.0 kernel, not mainline; asymptote isn't supported in mainline.
This patch can't be applied for a few reasons:
a) Asymptote isn't in mainline's arch/arm/tools/mach-types. This means that function machine_is_asymptote() doesn't exists, and this code can't compile.
b) Even if the machine were in mach-types, there's no board file for asymptote, so Russell King's automated mach-types cleanup script would flag asymptote for removal and eventually it'd go away. This is the same reason we recently removed Ventana support from tegra_wm8903.c. I'm not sure how this will work once we have device-tree-only boards; I guess we need to remove all the machine_is_foo() checks from the code and parameterize everything from DT instead.
-- nvpublic
| |