lkml.org 
[lkml]   [2011]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/5 v3] drivers/hid/hid-roccat.c: eliminate a null pointer dereference
    On Sat, 29 Oct 2011, Julia Lawall wrote:

    > It is not possible to take the lock in device if device is NULL.
    > The mutex_lock is thus moved after the NULL test. New error handling
    > labels are added at the end to differentiate between the cases where
    > different sets of locks should be unlocks, and between whether or not
    > reader should be freed (only on error).
    >
    > The semantic match that finds this problem is as follows:
    > (http://coccinelle.lip6.fr/)
    >
    > // <smpl>
    > @r@
    > expression E, E1;
    > identifier f;
    > statement S1,S2,S3;
    > @@
    >
    > if (E == NULL)
    > {
    > ... when != if (E == NULL || ...) S1 else S2
    > when != E = E1
    > *E->f
    > ... when any
    > return ...;
    > }
    > else S3
    > // </smpl>
    >
    > Signed-off-by: Julia Lawall <julia@diku.dk>

    Applied, thank you.

    --
    Jiri Kosina
    SUSE Labs


    \
     
     \ /
      Last update: 2011-11-01 15:17    [W:0.033 / U:0.092 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site