lkml.org 
[lkml]   [2011]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/26] ARM: pxa: add missing header inclusions
    On Sat, Oct 08, 2011 at 09:03:09AM +0100, Russell King - ARM Linux wrote:
    > On Fri, Oct 07, 2011 at 01:08:23PM +0800, Eric Miao wrote:
    > > On Sun, Oct 2, 2011 at 4:03 AM, Arnd Bergmann <arnd@arndb.de> wrote:
    > > > These resulted in build breakage in some configurations:
    > > >
    > > > arch/arm/mach-pxa/irq.c:132:39: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'icip_handle_irq'
    > > >
    > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > > > ---
    > > >  arch/arm/mach-pxa/irq.c |    1 +
    > > >  1 files changed, 1 insertions(+), 0 deletions(-)
    > > >
    > > > diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
    > > > index b09e848..848e96d 100644
    > > > --- a/arch/arm/mach-pxa/irq.c
    > > > +++ b/arch/arm/mach-pxa/irq.c
    > > > @@ -16,6 +16,7 @@
    > > >  #include <linux/module.h>
    > > >  #include <linux/interrupt.h>
    > > >  #include <linux/syscore_ops.h>
    > > > +#include <linux/ftrace.h>
    > >
    > > It's actually __irq_entry being defined in <linux/ftrace.h> and in turn
    > > __exception_irq_entry being conditionally defined to that.
    > >
    > > I think it's better to fix this in <asm/system.h> instead of in the
    > > cases where this macro is referenced?
    > >
    > > Russell?
    >
    > There's a patch in the patch system which fixes this (7115/3) but I
    > can't apply it because it doesn't apply to anything in my for-next
    > tree (it applies to the obsolete 'devel' branch which is rather old
    > now.)

    OK, I wasn't aware that devel was obsolete (though I guess if I'd paid
    closer attention to the commit dates I'd have suspected something).

    Anyhow, new patch in the tracker as 7115/4 rebased onto for-next.

    Jamie
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-10-08 12:25    [W:0.021 / U:1.524 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site