| | From | Eric Miao <> | | Date | Fri, 7 Oct 2011 13:08:23 +0800 | | Subject | Re: [PATCH 06/26] ARM: pxa: add missing header inclusions |
| |
On Sun, Oct 2, 2011 at 4:03 AM, Arnd Bergmann <arnd@arndb.de> wrote: > These resulted in build breakage in some configurations: > > arch/arm/mach-pxa/irq.c:132:39: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'icip_handle_irq' > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-pxa/irq.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c > index b09e848..848e96d 100644 > --- a/arch/arm/mach-pxa/irq.c > +++ b/arch/arm/mach-pxa/irq.c > @@ -16,6 +16,7 @@ > #include <linux/module.h> > #include <linux/interrupt.h> > #include <linux/syscore_ops.h> > +#include <linux/ftrace.h>
It's actually __irq_entry being defined in <linux/ftrace.h> and in turn __exception_irq_entry being conditionally defined to that.
I think it's better to fix this in <asm/system.h> instead of in the cases where this macro is referenced?
Russell?
> #include <linux/io.h> > #include <linux/irq.h> > > -- > 1.7.5.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|