lkml.org 
[lkml]   [2011]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] virtio: support unlocked queue kick
On Thu, Oct 06, 2011 at 12:15:36PM +1030, Rusty Russell wrote:
> On Wed, 05 Oct 2011 15:54:05 -0400, Christoph Hellwig <hch@infradead.org> wrote:
> > Split virtqueue_kick to be able to do the actual notification outside the
> > lock protecting the virtqueue. This patch was originally done by
> > Stefan Hajnoczi, but I can't find the original one anymore and had to
> > recreated it from memory. Pointers to the original or corrections for
> > the commit message are welcome.
>
> An alternative to this is to update the ring on every virtqueue_add_buf.
> MST discussed this for virtio_net, and I think it's better in general.
>
> The only reason that it wasn't written that way originally is that the
> barriers make add_buf slightly more expensive.
>
> Cheers,
> Rusty.

With event index, I'm not sure that's enough to make the kick lockless
anymore.


--
MST


\
 
 \ /
  Last update: 2011-10-06 11:21    [W:0.135 / U:0.664 seconds]
©2003-2014 Jasper Spaans. Advertise on this site