lkml.org 
[lkml]   [2011]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86: Removed superfluous parentheses in macro defs
    On 10/06/2011 03:22 PM, Alex Ben wrote:
    > 1) make it consistent with other constant macro deinitions, which
    > don't have parentheses, as they are really superfluous.

    Superfluous, yes, but it makes the expression read more regular.

    > diff --git a/arch/x86/include/asm/segment.h b/arch/x86/include/asm/segment.h
    > index 5e64171..92621c1 100644
    > --- a/arch/x86/include/asm/segment.h
    > +++ b/arch/x86/include/asm/segment.h
    > @@ -10,7 +10,7 @@
    > (((flags) & _AC(0x0000f0ff,ULL)) << 40) | \
    > (((limit) & _AC(0x000f0000,ULL)) << (48-16)) | \
    > (((base) & _AC(0x00ffffff,ULL)) << 16) | \
    > - (((limit) & _AC(0x0000ffff,ULL))))
    > + ((limit) & _AC(0x0000ffff,ULL)))
    >

    So NAK.

    -hpa


    --
    H. Peter Anvin, Intel Open Source Technology Center
    I work for Intel. I don't speak on their behalf.



    \
     
     \ /
      Last update: 2011-10-07 05:21    [W:0.027 / U:0.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site