Messages in this thread | | | Date | Thu, 6 Oct 2011 15:50:07 -0400 | From | Dave Jones <> | Subject | Re: RFC: virtualbox tainting. |
| |
On Thu, Oct 06, 2011 at 12:44:32PM -0700, Greg Kroah-Hartman wrote:
> > diff --git a/kernel/module.c b/kernel/module.c > > index 04379f92..d26c9a3 100644 > > --- a/kernel/module.c > > +++ b/kernel/module.c > > @@ -2653,6 +2653,10 @@ static int check_module_license_and_versions(struct module *mod) > > if (strcmp(mod->name, "ndiswrapper") == 0) > > add_taint(TAINT_PROPRIETARY_MODULE); > > > > + /* vbox is garbage. */ > > + if (strcmp(mod->name, "vboxdrv") == 0) > > + add_taint(TAINT_CRAP); > > Odds are we should have a list of these types of modules, as I think > there are a few others out there we should mark this way :)
possibly, though this is by far the leader (for us at least) today.
> But anyway, I like this, and I think I'll go add it to the openSUSE > kernels so we can avoid the numerous bug reports we get there as well > for this crappy driver. > > Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
I feel a bit dirty overloading TAINT_CRAP (even if the name is apropos). Should I introduce a TAINT_OUT_OF_TREE perhaps instead ?
Dave
| |