Messages in this thread |  | | | Date | Thu, 06 Oct 2011 20:44:57 +0200 | | Subject | Re: [PATCH v3] [SIGNED-OFF] ext4: don't work without procfs | | From | Olaf Titz <> |
| |
> It would make more sense as: > > +#ifdef CONFIG_PROC_FS > ext4_proc_root = proc_mkdir("fs/ext4", NULL); > if (!ext4_proc_root) > goto out5; > +#endif
Looks right, but even more logical would be to guard _all_ usage of ext4_proc_root (and, consequently, the declaration thereof) in #ifdef CONFIG_PROC_FS. Now it's at least necessary to always do null checks.
Olaf
|  |