lkml.org 
[lkml]   [2011]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] [SIGNED-OFF] ext4: don't work without procfs
From
> It would make more sense as:
>
> +#ifdef CONFIG_PROC_FS
> ext4_proc_root = proc_mkdir("fs/ext4", NULL);
> if (!ext4_proc_root)
> goto out5;
> +#endif

Looks right, but even more logical would be to guard _all_ usage of
ext4_proc_root (and, consequently, the declaration thereof) in #ifdef
CONFIG_PROC_FS. Now it's at least necessary to always do null checks.

Olaf


\
 
 \ /
  Last update: 2011-10-06 21:09    [from the cache]
©2003-2011 Jasper Spaans