lkml.org 
[lkml]   [2011]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] [SCSI] aacraid: use lower snprintf() limit
On Wed, Oct 05, 2011 at 05:19:12AM -0700, Achim Leubner wrote:
> Looks good so far. But do we really need the last two lines?
> > + if (len > 16)
> > + len = 16;
>

snprintf() returns the number of characters that it _would_ have
copied if it had space. We want to return the number of bytes
actually copied.

Again, the snprintf() values do fit so this change doesn't actually
make any difference.

regards,
dan carpenter


\
 
 \ /
  Last update: 2011-10-06 16:37    [from the cache]
©2003-2011 Jasper Spaans