lkml.org 
[lkml]   [2011]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] [SCSI] aacraid: use lower snprintf() limit
On Wed, Oct 05, 2011 at 09:35:13AM +0200, Rolf Eike Beer wrote:
> > dev->supplement_adapter_info.MfgPcbaSerialNo);
> > +
> > +
>
> One newline too much.
>

True. I wish checkpatch.pl checked for that...

> > + if (len > 16)
> > + len = 16;
>
> max()?

min() actually. I don't know that it improves the readability, but
can do.

regards,
dan carpenter


\
 
 \ /
  Last update: 2011-10-06 16:33    [from the cache]
©2003-2011 Jasper Spaans