lkml.org 
[lkml]   [2011]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[sparse stuff] bug in lp3944_led_set_brightness()
Hi Antonio,

I was going through some Sparse warnings and this one seems pretty
valid.

drivers/leds/leds-lp3944.c +292 23:
warning: mixing different enum types

284 static void lp3944_led_set_brightness(struct led_classdev *led_cdev,
285 enum led_brightness brightness)
286 {
287 struct lp3944_led_data *led = ldev_to_led(led_cdev);
288
289 dev_dbg(&led->client->dev, "%s: %s, %d\n",
290 __func__, led_cdev->name, brightness);
291
292 led->status = brightness;
^^^^^^^^^^^^^^^^^^^^^^^^
293 schedule_work(&led->work);
294 }

led->status should be values between 0-3. brightness is 0, 127 and
255.

regards,
dan carpenter


\
 
 \ /
  Last update: 2011-10-05 11:35    [W:0.085 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site