lkml.org 
[lkml]   [2011]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC] drivercore: Add helper macro for platform_driver boilerplate
    On Wed, Oct 5, 2011 at 4:02 AM, Mark Brown
    <broonie@opensource.wolfsonmicro.com> wrote:
    > On Tue, Oct 04, 2011 at 05:26:55PM -0600, Grant Likely wrote:
    >
    >> +/* Helper macro for drivers that don't do anything special in module
    >> + * init/exit.  This eliminates a lot of boilerplate */
    >> +#define module_platform_driver(__platform_driver) \
    >> +int __platform_driver##_init(void) \
    >> +{ \
    >> +     return platform_driver_register(&(__platform_driver)); \
    >> +} \
    >> +module_init(__platform_driver##_init); \
    >
    > This looks great but I would prefer it if the function complained if
    > something goes wrong - it makes problems a lot more discoverable when
    > they crop up.

    Yes. As discussed in the other thread, I think that should be added to
    the core code, and it can be in a separate patch. It doesn't belong
    in this macro.

    g.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-10-05 18:45    [W:0.021 / U:89.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site