[lkml]   [2011]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC][PATCH] ASoC: Fix sync reg_cache with the hardware in wm8990_resume
2011/10/5 Mark Brown <>:
> On Wed, Oct 05, 2011 at 06:16:49PM +0800, Axel Lin wrote:
>> Current code has off-by-one bug of checking WM8990_RESET.
>> Besides, according to wm8990 datasheet (2-wire serial control mode):
>> A control word consists of 24 bits. The first 8 bits are address bits,
>> the remaining 16 bits are data bits.
>> Current code uses 7 bits address bits and 9 bits data bits which is incorrect.
> We should just convert drivers like this to snd_soc_cache_sync().

Yes. It would be better convert it to snd_soc_cache_sync().
Just think this patch may be useful for 3.1 or earlier kernel version.


 \ /
  Last update: 2011-10-05 12:43    [W:0.031 / U:0.968 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site