Messages in this thread | | | Date | Tue, 4 Oct 2011 10:04:46 +0100 | From | Catalin Marinas <> | Subject | Re: [PATCH 2/4] kmemleak: Handle percpu memory allocation |
| |
On Tue, Oct 04, 2011 at 08:59:15AM +0100, Tejun Heo wrote: > On Mon, Oct 03, 2011 at 04:21:26PM +0100, Catalin Marinas wrote: > > The updated patch below adds specific kmemleak API for percpu pointers > > so that it only logs one call per allocation rather than the number of > > possible cpus (could be split in two, though the patch is relatively > > simple): > > The percpu part looks fine to me but I don't know how kmemleak works > to judge whether the kmemleak part is okay or not. This just avoids > false positives from slab and would still require bumping up the early > log memory as # of cpus increases, right?
No, there is only one kmemleak call for each __percpu pointer (to the specific kmemleak_*_percpu function). The kmemleak expands the percpu pointer into corresponding blocks for each cpu but the early log only stores a single call.
> For percpu part, > > Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
> How do you want to route this? If kmemleak patches get routed through > -mm, please feel free to send it to Andrew with Acked-by's added.
I'll push them to -next for now and (depending on how late the merge window opens) I can send a pull request to Linus.
-- Catalin
| |