lkml.org 
[lkml]   [2011]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2/2] module: Re-enable dynamic debugging for GPL-compatible OOT modules
    Date
    On Mon, 31 Oct 2011 13:44:17 +0000, Ben Hutchings <ben@decadent.org.uk> wrote:
    Non-text part: multipart/signed
    > On Mon, 2011-10-31 at 12:29 +1030, Rusty Russell wrote:
    > > On Fri, 28 Oct 2011 04:38:14 +0100, Ben Hutchings <ben@decadent.org.uk> wrote:
    > > > Dynamic debugging was enabled for GPL-compatible out-of-tree modules
    > > > until my addition of TAINT_OOT_MODULE. It should continue to be
    > > > enabled now.
    > >
    > > Please just remove the test entirely.
    > >
    > > AFAICT there's nothing unique to dynamic debug which means it should
    > > avoid taint. If it oopses, we'll learn all about tainting in the oops
    > > message.
    >
    > It looks like the dynamic debug facility is not meant to be available to
    > proprietary modules.

    That was my guess too, but Mathieu (the author) said it was about
    malformed modules:

    On Wed, 26 Oct 2011 02:15:21 -0400:
    > This check for tainted modules was first introduced with markers, and
    > then used by tracepoints, and then also by dynamic debug. The rationale
    > for this check was mainly to ensure that the marker/tracepoint code
    > would not trigger a crash when loading a module with incompatible module
    > header, originally compiled for an older kernel, into a newer kernel.
    > This problem would happen even if the said module does not contain any
    > marker/tracepoint, because we happen to try to use fields that are
    > non-existent in the module header.

    This is pretty bogus: since they forced the module in the first place,
    they can handle the explosion.

    So we should drop it altogether.

    Thanks,
    Rusty.


    \
     
     \ /
      Last update: 2011-11-01 03:19    [W:0.022 / U:64.512 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site