Messages in this thread | | | Date | Mon, 3 Oct 2011 17:35:49 -0700 | From | mark gross <> | Subject | Re: [: Re: [RFC] wake up notifications and suspend blocking (aka more wakelock stuff)] |
| |
On Mon, Oct 03, 2011 at 09:32:26AM +0100, Alan Cox wrote: > On Sun, 2 Oct 2011 09:48:49 -0700 > mark gross <markgross@thegnar.org> wrote: > > > Forwarding to bigger group for discussion. > > Looks clean enough - only question I have is do we need a separate > 'suspend block' or can latency do it -suspend is a very very high latency > event. I guess the suspend block is clearer in intent than abusing latency > but I do wonder if the actual suspend path should also check latency > constraints too. If I've asked for 5mS latency then suspend is a wrong > choice! > I don't think over loading the meaning of cpu_dma_latency would work well for this. If cpu_dma_latency constraint is > 5mS then EFAIL a suspend attempt? feels clunky.
If you use less than then anyone using a constraint (like some wifi and audio) would block suspend. also not so good.
The poster child for needing this is the USB gadget device with associated charging over USB. Here we can't sleep because we'd have a hard time meeting USB spec if we did. Also, we don't want to sleep while charging if charging is under OS control. (checking temperature is tricky while suspended.)
--mark
| |