Messages in this thread | | | Date | Mon, 03 Oct 2011 17:22:04 -0700 | From | Venkat Subbiah <> | Subject | Re: [PATCH] MIPS: Octeon: Mark octeon_wdt interrupt as IRQF_NO_THREAD |
| |
On 10/03/2011 04:30 PM, Venkat Subbiah wrote: > This is to exclude it from force threading to allow RT patch set to work. > > The watchdog timers are per-CPU and the addresses of register that reset > the timer are calculated based on the current CPU. Therefore we cannot > allow it to run on a thread on a different CPU. Also we only do a > single register write, which is much faster than scheduling a handler > thread. > > And while on this line remove IRQF_DISABLED as this flag is a NOP. > > > Signed-off-by: Venkat Subbiah<venkat.subbiah@cavium.com> > Acked-by: David Daney<david.daney@cavium.com> > --- > drivers/watchdog/octeon-wdt-main.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/watchdog/octeon-wdt-main.c b/drivers/watchdog/octeon-wdt-main.c > index 945ee83..7c0d863 100644 > --- a/drivers/watchdog/octeon-wdt-main.c > +++ b/drivers/watchdog/octeon-wdt-main.c > @@ -402,7 +402,7 @@ static void octeon_wdt_setup_interrupt(int cpu) > irq = OCTEON_IRQ_WDOG0 + core; > > if (request_irq(irq, octeon_wdt_poke_irq, > - IRQF_DISABLED, "octeon_wdt", octeon_wdt_poke_irq)) > + IRQF_NO_THREAD, "octeon_wdt", octeon_wdt_poke_irq)) > panic("octeon_wdt: Couldn't obtain irq %d", irq); > > cpumask_set_cpu(cpu,&irq_enabled_cpus); Sending it to kernel watchdog maintainers. Forgot to include them in the prior email.
Thanks, Venkat
| |