lkml.org 
[lkml]   [2011]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Xen-devel] [PATCH 7/9] xen/xenbus: Check before dereferencing it.
    On Fri, Sep 30, 2011 at 09:01:21AM +0100, Ian Campbell wrote:
    > On Thu, 2011-09-29 at 20:52 +0100, Konrad Rzeszutek Wilk wrote:
    > > . we do the check whether 'xdev' is NULL - but after we have
    > > dereferenced it.
    > >
    > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    > > ---
    > > drivers/xen/xenbus/xenbus_probe_backend.c | 3 ++-
    > > 1 files changed, 2 insertions(+), 1 deletions(-)
    > >
    > > diff --git a/drivers/xen/xenbus/xenbus_probe_backend.c b/drivers/xen/xenbus/xenbus_probe_backend.c
    > > index 60adf91..331589a 100644
    > > --- a/drivers/xen/xenbus/xenbus_probe_backend.c
    > > +++ b/drivers/xen/xenbus/xenbus_probe_backend.c
    > > @@ -103,10 +103,11 @@ static int xenbus_uevent_backend(struct device *dev,
    > > return -ENODEV;
    > >
    > > xdev = to_xenbus_device(dev);
    >
    > to_xenbus_device is just container_of. The only way it would return NULL
    > is if dev == offsetof(struct xenbus_device, dev), which isn't terribly
    > likely. A more likely error would be dev == NULL and we just checked
    > above.
    >
    > > - bus = container_of(xdev->dev.bus, struct xen_bus_type, bus);
    > > if (xdev == NULL)
    > > return -ENODEV;

    Hm, in which case this 'xdev == NULL' is pointless. Will remove it.


    \
     
     \ /
      Last update: 2011-10-03 18:29    [W:0.024 / U:59.996 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site