lkml.org 
[lkml]   [2011]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] udf : enable error print in udf_read_tagged().
From
Date
On Mon, 2011-10-03 at 13:55 +0900, Namjae Jeon wrote:
> While reading metadata, if a problem occurs,
> Print out only one of the five case.(It also does not show a checksum properly.)
> Because currently it have been disable by undef udf_debug.
> If there is a problem with scratched disc or loader, the user needs to know which error happened.
> And I use pr_fmt instead of printk by joe's suggestion. I try to modify totally it to pr_fmt also.
[]
> diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h
[]
> @@ -21,7 +23,7 @@
> #ifdef UDFFS_DEBUG
> #define udf_debug(f, a...) \
> do { \
> - printk(KERN_DEBUG "UDF-fs DEBUG %s:%d:%s: ", \
> + pr_debug("DEBUG %s:%d:%s: ", \
> __FILE__, __LINE__, __func__); \
> printk(f, ##a); \

This isn't the same.

You should probably just use

#define udf_debug(fmt, ...) \
pr_debug("DEBUG %s:%d:%s: " fmt, \
__FILE__, __LINE__, __func__, __VA_ARGS__)

or maybe let dynamic_debug add
__FILE__, __LINE__ and __func__
via the appropriate controls,
so this might be appropriate.

#define udf_debug(fmt, ...) \
pr_debug("DEBUG " fmt, __VA_ARGS__)




\
 
 \ /
  Last update: 2011-10-03 07:41    [W:0.028 / U:1.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site