Messages in this thread | | | Date | Mon, 3 Oct 2011 14:41:38 +0400 | From | Glauber Costa <> | Subject | Re: [PATCH v4 1/8] Basic kernel memory functionality for the Memory Controller |
| |
On 10/03/2011 02:41 PM, Kirill A. Shutemov wrote: > On Mon, Oct 03, 2011 at 02:18:36PM +0400, Glauber Costa wrote: >> This patch lays down the foundation for the kernel memory component >> of the Memory Controller. >> >> As of today, I am only laying down the following files: >> >> * memory.independent_kmem_limit >> * memory.kmem.limit_in_bytes (currently ignored) >> * memory.kmem.usage_in_bytes (always zero) >> >> Signed-off-by: Glauber Costa<glommer@parallels.com> >> CC: Paul Menage<paul@paulmenage.org> >> CC: Greg Thelen<gthelen@google.com> > > Reviewed-by: Kirill A. Shutemov<kirill@shutemov.name> > > One comment bellow. > >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> index ebd1e86..8aaf4ce 100644 >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -72,8 +72,6 @@ static int really_do_swap_account __initdata = 0; >> #else >> #define do_swap_account (0) >> #endif >> - >> - >> /* >> * Statistics for memory cgroup. >> */ > > Please drop this hunk. > Just did. Thanks for noticing, I missed this one.
| |