Messages in this thread | | | Date | Sun, 30 Oct 2011 03:29:59 +0900 | Subject | Re: [PATCH net-next] w5300: add WIZnet W5300 Ethernet driver | From | Taehun Kim <> |
| |
2011/10/25 David Miller <davem@davemloft.net>: > From: Taehun Kim <kth3321@gmail.com> > Date: Sat, 22 Oct 2011 17:41:56 +0900 > >> +struct wiz_private { >> + void __iomem *base; >> + struct net_device *dev; >> + u8 rxbuf_conf[MAX_SOCK_NUM]; >> + u8 txbuf_conf[MAX_SOCK_NUM]; >> + struct net_device_stats stats; >> + struct napi_struct napi; >> + spinlock_t lock; >> + u32 msg_enable; >> +}; > > You don't need to have a private net_device_stats, just use the > one in struct net_device, and then you can also get rid of your > private ->ndo_get_stats() method. >
Thank you for your feedback :)
I am working on this drive by referencing other Ethernet drivers. I have one question.
Should I suggest the updated driver patch to this thread or new thread? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |