lkml.org 
[lkml]   [2011]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] VirtioConsole support.
    On 10/27/11 19:55, Joe Perches wrote:
    >
    > @@ -845,6 +857,19 @@ struct hvc_struct *hvc_alloc(uint32_t vtermno, int data,
    > kref_init(&hp->kref);
    >
    > INIT_WORK(&hp->tty_resize, hvc_set_winsz);
    > + /*
    > + * make each console its own struct console.
    > + * No need to do allocation and copy under lock.
    > + */
    > + cp = kzalloc(sizeof(*cp), GFP_KERNEL);
    > + if (!cp) {
    > + kfree(hp);
    > + mutex_unlock(&hvc_ports_mutex);
    > + return ERR_PTR(-ENOMEM);
    > + }
    > + memcpy(cp, &hvc_console, sizeof(*cp));
    > The kzalloc should be kmalloc as the allocated
    > memory is immediately overwritten.

    Even better would be kmemdup().

    --
    Sent by an employee of the Qualcomm Innovation Center, Inc.
    The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.



    \
     
     \ /
      Last update: 2011-10-28 20:21    [W:0.020 / U:30.200 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site