lkml.org 
[lkml]   [2011]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 5/6] slub: Only IPI CPUs that have per cpu obj to flush
    On Sun, 23 Oct 2011, Gilad Ben-Yossef wrote:

    > diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h
    > index f58d641..b130f61 100644
    > --- a/include/linux/slub_def.h
    > +++ b/include/linux/slub_def.h
    > @@ -102,6 +102,9 @@ struct kmem_cache {
    > */
    > int remote_node_defrag_ratio;
    > #endif
    > +
    > + /* Which CPUs hold local slabs for this cache. */
    > + cpumask_var_t cpus_with_slabs;
    > struct kmem_cache_node *node[MAX_NUMNODES];
    > };

    Please do not add fields to structures for passing parameters to
    functions. This just increases the complexity of the patch and extends a
    structures needlessly.

    > diff --git a/mm/slub.c b/mm/slub.c
    > index 7c54fe8..f8cbf2d 100644
    > --- a/mm/slub.c
    > +++ b/mm/slub.c
    > @@ -1948,7 +1948,18 @@ static void flush_cpu_slab(void *d)
    >
    > static void flush_all(struct kmem_cache *s)
    > {
    > - on_each_cpu(flush_cpu_slab, s, 1);
    > + struct kmem_cache_cpu *c;
    > + int cpu;
    > +
    > + for_each_online_cpu(cpu) {
    > + c = per_cpu_ptr(s->cpu_slab, cpu);
    > + if (c && c->page)
    > + cpumask_set_cpu(cpu, s->cpus_with_slabs);
    > + else
    > + cpumask_clear_cpu(cpu, s->cpus_with_slabs);
    > + }
    > +
    > + on_each_cpu_mask(s->cpus_with_slabs, flush_cpu_slab, s, 1);
    > }


    You do not need s->cpus_with_slabs to be in kmem_cache. Make it a local
    variable instead.



    \
     
     \ /
      Last update: 2011-10-28 06:09    [W:0.037 / U:30.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site