Messages in this thread | | | Date | Fri, 28 Oct 2011 18:00:02 +0530 | From | Rabin Vincent <> | Subject | Re: [PATCH] x86: call stop_machine_text_poke() on all CPUs |
| |
On Fri, Oct 28, 2011 at 11:28:39AM +0900, Masami Hiramatsu wrote: > (2011/10/27 16:54), Rabin Vincent wrote: > > It appears that stop_machine_text_poke() wants to be called on all CPUs, > > like it's done from text_poke_smp(). Fix text_poke_smp_batch() to do > > this. > > cpu_mask==NULL finally falls back to cpu_online_mask, but even though > it should be specified correctly.
Not quite. Passing NULL to __stop_machine means that the function will be called on any one CPU only, while passing cpu_online_mask means that the function will be called on all CPUs. So this patch is a behaviour change/bug fix, not just a clarification.
| |