[lkml]   [2011]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH V1 00/17] ext4: Add inline data support.
    On Wed, 26 Oct 2011 15:32:24 +0800, Tao Ma said:

    > Currently I use all the space between i_extra_isize and inode_size if
    > inode_size = 256. For inode_size > 256, half of that space is used so as
    > to leave some space for other xattrs.

    I didn't check the code too closely - does this code DTRT if the user tries to
    then attach a moby-sized xattr (or set of xattrs - if it's got a security.selinux
    tag on it, and a security.capabilities xattr, and a user xattr or two, things are
    going to be getting full).

    > This is only a V1 and there are still something to do(e.g. I am thinking
    > of using unused extent space), but I'd like to send it out earlier so
    > that it can be reviewed ASAP.

    If this works out, would it make sense to investigate doing this for all
    tails in a V2? So if your file was 4099 bytes long, you could save allocating
    a second block. Assuming random distribution of tail sizes, this wil save
    an average of (space avail for tail)/(blocksize) per file.
    [unhandled content-type:application/pgp-signature]
     \ /
      Last update: 2011-10-27 09:13    [W:0.022 / U:237.348 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site