lkml.org 
[lkml]   [2011]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/6] Staging: hv: mousevsc: Make boolean states boolean
    From
    Date
    On Wed, 2011-10-26 at 08:07 +0200, Greg KH wrote:
    > On Tue, Oct 25, 2011 at 05:03:47PM -0700, Joe Perches wrote:
    > > On Tue, 2011-10-25 at 17:19 -0700, K. Y. Srinivasan wrote:
    > > > Make some state that is boolean in nature, a boolean variable.
    > > []
    > > > diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
    > > []
    > > @@ -148,7 +148,7 @@ struct mousevsc_prt_msg {
    > > > */
    > > > struct mousevsc_dev {
    > > > struct hv_device *device;
    > > > - unsigned char init_complete;
    > > > + bool init_complete;
    > > > struct mousevsc_prt_msg protocol_req;
    > > > struct mousevsc_prt_msg protocol_resp;
    > > > /* Synchronize the request/response if needed */
    > > > @@ -159,7 +159,7 @@ struct mousevsc_dev {
    > > > unsigned char *report_desc;
    > > > u32 report_desc_size;
    > > > struct hv_input_dev_info hid_dev_info;
    > > > - int connected;
    > > > + bool connected;
    > > > struct hid_device *hid_device;
    > > > };
    > >
    > > One of the bools should be moved to be adjacent to the other.
    > For a mouse driver, it really doesn't matter.

    'course it doesn't matter, just like whitespace
    doesn't matter. It's just done for form's sake.




    \
     
     \ /
      Last update: 2011-10-27 00:49    [W:0.022 / U:1.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site