Messages in this thread |  | | | Date | Tue, 25 Oct 2011 11:20:06 -0500 | | From | Kyle Manna <> | | Subject | Re: [PATCH v2 1/6] mfd: TPS65910: Handle non-existent devices |
| |
On 10/25/2011 11:01 AM, Mark Brown wrote: >> Unfortunately on this chip there aren't any identification or >> > constant test registers. The only register close is the >> > JTAGVERNUM_REG and that's will change across silicon revisions. > It seems like a more useful implementation would be to have the driver > read and display this revision number during boot, this will give you > the register readability check and also let us know the device revision > which might be useful for diagnostics. I reviewed the register and the lowest 4 bits are the silicon revision (my hw reads 0x1) and the upper four bits should always be zero. I will update the patch to silently succeed as long a valid value is read, else print a error including that value and return -ENODEV.
Should I submit an entire updated patch series or just submit a single patch in reply to this? Did you have any other comments on the rest of the series?
- Kyle
|  |