lkml.org 
[lkml]   [2011]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/6] mfd: TPS65910: Handle non-existent devices
On 10/25/2011 11:01 AM, Mark Brown wrote:
>> Unfortunately on this chip there aren't any identification or
>> > constant test registers. The only register close is the
>> > JTAGVERNUM_REG and that's will change across silicon revisions.
> It seems like a more useful implementation would be to have the driver
> read and display this revision number during boot, this will give you
> the register readability check and also let us know the device revision
> which might be useful for diagnostics.
I reviewed the register and the lowest 4 bits are the silicon revision
(my hw reads 0x1) and the upper four bits should always be zero. I will
update the patch to silently succeed as long a valid value is read, else
print a error including that value and return -ENODEV.

Should I submit an entire updated patch series or just submit a single
patch in reply to this? Did you have any other comments on the rest of
the series?

- Kyle


\
 
 \ /
  Last update: 2011-10-25 18:23    [from the cache]
©2003-2011 Jasper Spaans