lkml.org 
[lkml]   [2011]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv5 16/19] power_supply: Convert all users to new usb_phy
Hi,

On Mon, Oct 10, 2011 at 11:08:12PM +0400, Anton Vorontsov wrote:
> On Mon, Oct 03, 2011 at 04:10:55PM +0300, Heikki Krogerus wrote:
> [...]
> > > +static inline int
> > > +isp1704_read(struct isp1704_charger *isp, u32 reg)
>
> Cosmetic nitpick: I don't see any reason to break this into two lines.
>
> > > +{
> > > + return usb_phy_io_read(isp->xceiv, reg);
> > > +}
> > > +
> > > +static inline int
> > > +isp1704_write(struct isp1704_charger *isp, u32 val, u32 reg)
>
> Same here.
>
> I assume you want this patch to go via some other tree, so feel
> free to add
>
> Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
>
> Thanks!

Thanks Anton. I'll change them.

--
heikki


\
 
 \ /
  Last update: 2011-10-24 12:17    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site