Messages in this thread | | | Date | Mon, 24 Oct 2011 12:10:21 +0200 | From | Mark Brown <> | Subject | Re: [RFC][PATCH 3/3] ASoC: wm8940: Do not left shift the div parameter in wm8940_set_dai_clkdiv |
| |
On Mon, Oct 24, 2011 at 11:35:12AM +0800, Axel Lin wrote: > Just check with other codec drivers, we do left shit div for > the corresponding bits from the caller in all other drivers. > I don't find the caller calling wm8940_set_dai_clkdiv now, > just make the behavior consistent with other drivers.
The semantics for the clkdivs are entirely defined by the individual drivers - there's no actual standard here and I guess this may break some out of tree machines that people have. If we're going to a cleanup here it'd be better to improve the driver to figure out the divider configurations automatically as far as possible.
| |