[lkml]   [2011]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 13/X] uprobes: introduce UTASK_SSTEP_TRAPPED logic
    On Wed, Oct 19, 2011 at 11:53:44PM +0200, Oleg Nesterov wrote:
    > Finally, add UTASK_SSTEP_TRAPPED state/code to handle the case when
    > xol insn itself triggers the signal.
    > In this case we should restart the original insn even if the task is
    > already SIGKILL'ed (say, the coredump should report the correct ip).
    > This is even more important if the task has a handler for SIGSEGV/etc,
    > The _same_ instruction should be repeated again after return from the
    > signal handler, and SSTEP can never finish in this case.


    Not sure I understand this completely...

    When you say 'correct ip' you mean the original vaddr where we now have
    a uprobe breakpoint and not the xol copy, right?

    Coredump needs to report the correct ip, but should it also not report
    correctly the instruction that caused the signal? Ergo, shouldn't we
    put the original instruction back at the uprobed vaddr?


     \ /
      Last update: 2011-10-22 09:23    [W:0.022 / U:0.176 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site