lkml.org 
[lkml]   [2011]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 23/49] clocksource: irq: Remove IRQF_DISABLED
    Date
    Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
    We run all interrupt handlers with interrupts disabled
    and we even check and yell when an interrupt handler
    returns with interrupts enabled (see commit [b738a50a:
    genirq: Warn when handler enables interrupts]).

    So now this flag is a NOOP and can be removed.

    Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
    ---
    drivers/clocksource/cs5535-clockevt.c | 2 +-
    drivers/clocksource/dw_apb_timer.c | 3 +--
    drivers/clocksource/sh_cmt.c | 2 +-
    drivers/clocksource/sh_mtu2.c | 2 +-
    drivers/clocksource/sh_tmu.c | 2 +-
    drivers/clocksource/tcb_clksrc.c | 2 +-
    6 files changed, 6 insertions(+), 7 deletions(-)

    diff --git a/drivers/clocksource/cs5535-clockevt.c b/drivers/clocksource/cs5535-clockevt.c
    index b7dab32..2d3715f 100644
    --- a/drivers/clocksource/cs5535-clockevt.c
    +++ b/drivers/clocksource/cs5535-clockevt.c
    @@ -133,7 +133,7 @@ static irqreturn_t mfgpt_tick(int irq, void *dev_id)

    static struct irqaction mfgptirq = {
    .handler = mfgpt_tick,
    - .flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER,
    + .flags = IRQF_NOBALANCING | IRQF_TIMER,
    .name = DRV_NAME,
    };

    diff --git a/drivers/clocksource/dw_apb_timer.c b/drivers/clocksource/dw_apb_timer.c
    index 580f870..55eb8ad 100644
    --- a/drivers/clocksource/dw_apb_timer.c
    +++ b/drivers/clocksource/dw_apb_timer.c
    @@ -243,8 +243,7 @@ dw_apb_clockevent_init(int cpu, const char *name, unsigned rating,
    dw_ced->irqaction.dev_id = &dw_ced->ced;
    dw_ced->irqaction.irq = irq;
    dw_ced->irqaction.flags = IRQF_TIMER | IRQF_IRQPOLL |
    - IRQF_NOBALANCING |
    - IRQF_DISABLED;
    + IRQF_NOBALANCING;

    dw_ced->eoi = apbt_eoi;
    err = setup_irq(irq, &dw_ced->irqaction);
    diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c
    index ca09bc4..3bc55c4 100644
    --- a/drivers/clocksource/sh_cmt.c
    +++ b/drivers/clocksource/sh_cmt.c
    @@ -641,7 +641,7 @@ static int sh_cmt_setup(struct sh_cmt_priv *p, struct platform_device *pdev)
    p->irqaction.name = dev_name(&p->pdev->dev);
    p->irqaction.handler = sh_cmt_interrupt;
    p->irqaction.dev_id = p;
    - p->irqaction.flags = IRQF_DISABLED | IRQF_TIMER | \
    + p->irqaction.flags = IRQF_TIMER | \
    IRQF_IRQPOLL | IRQF_NOBALANCING;

    /* get hold of clock */
    diff --git a/drivers/clocksource/sh_mtu2.c b/drivers/clocksource/sh_mtu2.c
    index db8d595..0521f03 100644
    --- a/drivers/clocksource/sh_mtu2.c
    +++ b/drivers/clocksource/sh_mtu2.c
    @@ -282,7 +282,7 @@ static int sh_mtu2_setup(struct sh_mtu2_priv *p, struct platform_device *pdev)
    p->irqaction.handler = sh_mtu2_interrupt;
    p->irqaction.dev_id = p;
    p->irqaction.irq = irq;
    - p->irqaction.flags = IRQF_DISABLED | IRQF_TIMER | \
    + p->irqaction.flags = IRQF_TIMER | \
    IRQF_IRQPOLL | IRQF_NOBALANCING;

    /* get hold of clock */
    diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c
    index 079e96a..306d212 100644
    --- a/drivers/clocksource/sh_tmu.c
    +++ b/drivers/clocksource/sh_tmu.c
    @@ -385,7 +385,7 @@ static int sh_tmu_setup(struct sh_tmu_priv *p, struct platform_device *pdev)
    p->irqaction.handler = sh_tmu_interrupt;
    p->irqaction.dev_id = p;
    p->irqaction.irq = irq;
    - p->irqaction.flags = IRQF_DISABLED | IRQF_TIMER | \
    + p->irqaction.flags = IRQF_TIMER | \
    IRQF_IRQPOLL | IRQF_NOBALANCING;

    /* get hold of clock */
    diff --git a/drivers/clocksource/tcb_clksrc.c b/drivers/clocksource/tcb_clksrc.c
    index 79c47e8..1963b93 100644
    --- a/drivers/clocksource/tcb_clksrc.c
    +++ b/drivers/clocksource/tcb_clksrc.c
    @@ -175,7 +175,7 @@ static irqreturn_t ch2_irq(int irq, void *handle)

    static struct irqaction tc_irqaction = {
    .name = "tc_clkevt",
    - .flags = IRQF_TIMER | IRQF_DISABLED,
    + .flags = IRQF_TIMER,
    .handler = ch2_irq,
    };

    --
    1.7.1


    \
     
     \ /
      Last update: 2011-10-22 12:11    [W:0.034 / U:1.456 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site