Messages in this thread |  | | | From | "Aneesh Kumar K.V" <> | | Subject | Re: [PATCH -V7 21/26] richacl: xattr mapping functions | | Date | Thu, 20 Oct 2011 14:00:02 +0530 |
| |
On Wed, 19 Oct 2011 18:20:21 -0400, "J. Bruce Fields" <bfields@fieldses.org> wrote: > On Tue, Oct 18, 2011 at 09:02:56PM +0530, Aneesh Kumar K.V wrote: > > +#define RICHACL_XATTR "system.richacl" > > + > > +struct richace_xattr { > > + __le16 e_type; > > + __le16 e_flags; > > + __le32 e_mask; > > + __le32 e_id; > > + char e_who[0]; > > +}; > > Does it really make sense to use a string here just to pick between the > three choices OWNER@, GROUP@, and EVERYONE@? Why not just another small > integer? Is the goal to expand this somehow eventually?
I guess Andreas wanted the disk layout to be able to store user@domain format if needed. That should make the layout flexible enough so that we won't have to add another xattr later.
-aneesh
|  |