lkml.org 
[lkml]   [2011]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/24] Staging: comedi: fix printk issue in cb_pcimdda.c
    Date
    This is a patch to the cb_pcimdda.c file that fixes up a printk warning
    found by the checkpatch.pl tool
    Converted printks to dev_printk.

    Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
    ---
    drivers/staging/comedi/drivers/cb_pcimdda.c | 14 ++++++--------
    1 files changed, 6 insertions(+), 8 deletions(-)

    diff --git a/drivers/staging/comedi/drivers/cb_pcimdda.c b/drivers/staging/comedi/drivers/cb_pcimdda.c
    index 8c981a8..6f8ba18 100644
    --- a/drivers/staging/comedi/drivers/cb_pcimdda.c
    +++ b/drivers/staging/comedi/drivers/cb_pcimdda.c
    @@ -300,7 +300,8 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
    return err;

    /* Output some info */
    - printk("comedi%d: %s: ", dev->minor, thisboard->name);
    + dev_dbg(dev->hw_dev, "comedi%d: %s: attached\n", dev->minor,
    + thisboard->name);

    /*
    * Initialize dev->board_name. Note that we can use the "thisboard"
    @@ -341,7 +342,7 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
    break;
    case DIO_INTERNAL:
    default:
    - printk("DIO_INTERNAL not implemented yet!\n");
    + dev_err(dev->hw_dev, "DIO_INTERNAL not implemented yet!\n");
    return -ENXIO;
    break;
    }
    @@ -351,8 +352,6 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)

    devpriv->attached_successfully = 1;

    - printk("attached\n");
    -
    return 1;
    }

    @@ -381,8 +380,8 @@ static int detach(struct comedi_device *dev)
    }

    if (devpriv->attached_successfully && thisboard)
    - printk("comedi%d: %s: detached\n", dev->minor,
    - thisboard->name);
    + dev_dbg(dev->hw_dev, "comedi%d: %s: detached\n",
    + dev->minor, thisboard->name);

    }

    @@ -503,7 +502,6 @@ static int probe(struct comedi_device *dev, const struct comedi_devconfig *it)
    }
    }

    - printk("cb_pcimdda: No supported ComputerBoards/MeasurementComputing "
    - "card found at the requested position\n");
    + dev_err(dev->hw_dev, "No supported ComputerBoards/MeasurementComputing card found at the requested position\n");
    return -ENODEV;
    }
    --
    1.7.6.4


    \
     
     \ /
      Last update: 2011-10-20 08:25    [W:5.349 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site