lkml.org 
[lkml]   [2011]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/9] user namespace: clamp down users of cap_raised
Quoting David Howells (dhowells@redhat.com):
>
> > #define NS_IS_NON_DEFAULT (current_user_ns() != &init_user_ns)
>
> How about:
>
> #define IN_ROOT_USER_NS (current_user_ns() == &init_user_ns)
>
> And then:
>
> if (!IN_ROOT_USER_NS() || !cap_raised(current_cap(), CAP_SYS_ADMIN)) {
>
> I think it reads better.

My feeble brain does seem to process this faster.

I might make it !IN_INIT_USER_NS(), to be more consistent with
&init_user_ns.

Vasiliy had months ago suggested moving the whole idiom into its own
helper function. Somehow I couldn't make the jump to this then...

thanks all,
-serge


\
 
 \ /
  Last update: 2011-10-20 15:19    [W:0.124 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site