lkml.org 
[lkml]   [2011]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH] x86: Add a sanity test of x86 decoder

    * Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:

    > >> +static void dump_stream(FILE *fp, const char *msg, struct insn *insn)
    > >> +{
    > >> + int i;
    > >> + fprintf(fp, "%s:\n code:", msg);
    > >
    > > missing newline.
    >
    > This prints a header of code sequence, so that we'll see a
    > message like below;

    I mean, it's missing the standard newline between local variable(s)
    and the first statement:

    static void dump_stream(FILE *fp, const char *msg, struct insn *insn)
    {
    int i;

    fprintf(fp, "%s:\n code:", msg);
    [...]

    We do this for readability.

    Thanks,

    Ingo


    \
     
     \ /
      Last update: 2011-10-19 08:47    [W:0.030 / U:2.056 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site