lkml.org 
[lkml]   [2011]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 7/7] perf hists browser: Do not exit on tab key with single event
    Date
    From: David Ahern <dsahern@gmail.com>

    TUI help states for multiple event sessions the TAB/UNTAB keys are used
    to switch events. For single event sessions (e.g., the default) the tab
    key currently causes the tui to exit. Change that to do nothing since
    there is not no second event to switch to.

    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/1319045867-12728-1-git-send-email-dsahern@gmail.com
    Signed-off-by: David Ahern <dsahern@gmail.com>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/ui/browsers/hists.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/tools/perf/util/ui/browsers/hists.c b/tools/perf/util/ui/browsers/hists.c
    index 94e1ab0..d762875 100644
    --- a/tools/perf/util/ui/browsers/hists.c
    +++ b/tools/perf/util/ui/browsers/hists.c
    @@ -864,6 +864,8 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
    switch (key) {
    case NEWT_KEY_TAB:
    case NEWT_KEY_UNTAB:
    + if (nr_events == 1)
    + continue;
    /*
    * Exit the browser, let hists__browser_tree
    * go to the next or previous
    --
    1.6.2.5


    \
     
     \ /
      Last update: 2011-10-19 20:25    [W:0.038 / U:1.848 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site