lkml.org 
[lkml]   [2011]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCHv3 6/7] input/cma3000_d0x: Unwind reverse order of init
Ok,

I remove that patch and fix it for the new cmr3000 driver


Thanks!

On Tue, Oct 18, 2011 at 19:03, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Tuesday, October 18, 2011 09:57:24 AM Ricardo Ribalda Delgado wrote:
>> Hello Dmitry
>>
>>  You are right, and also could be a good idea to init the irq, only
>> after the input device has been registered. Dont you think so?
>
> Input core is constructed in such way that it is safe to call
> input_report_*() and input_event() on properly allocated input device,
> even if it has not been registered yet, the events will simply be
> dropped.
>
> So no, it is not necessary and doing so is quite often complicates
> error handling in probe() routines.
>
> Thanks.
>
> --
> Dmitry
>



--
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-10-18 19:13    [W:0.417 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site