lkml.org 
[lkml]   [2011]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -V7 04/26] vfs: Add a comment to inode_permission()
    Date
    From: Andreas Gruenbacher <agruen@kernel.org>

    Acked-by: David Howells <dhowells@redhat.com>
    Signed-off-by: Andreas Gruenbacher <agruen@kernel.org>
    Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
    ---
    fs/namei.c | 6 ++++--
    1 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/fs/namei.c b/fs/namei.c
    index 276cd30..9061157 100644
    --- a/fs/namei.c
    +++ b/fs/namei.c
    @@ -221,7 +221,7 @@ static int check_acl(struct inode *inode, int mask)
    }

    /*
    - * This does basic POSIX ACL permission checking
    + * This does the basic permission checking
    */
    static int acl_permission_check(struct inode *inode, int mask)
    {
    @@ -271,7 +271,7 @@ int generic_permission(struct inode *inode, int mask)
    int ret;

    /*
    - * Do the basic POSIX ACL permission checks.
    + * Do the basic permission checks.
    */
    ret = acl_permission_check(inode, mask);
    if (ret != -EACCES)
    @@ -335,6 +335,8 @@ static inline int do_inode_permission(struct inode *inode, int mask)
    * We use "fsuid" for this, letting us set arbitrary permissions
    * for filesystem access without changing the "normal" uids which
    * are used for other things.
    + *
    + * When checking for MAY_APPEND, MAY_WRITE must also be set in @mask.
    */
    int inode_permission(struct inode *inode, int mask)
    {
    --
    1.7.5.4


    \
     
     \ /
      Last update: 2011-10-18 17:37    [W:0.032 / U:385.520 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site