Messages in this thread | | | From | Ricardo Ribalda Delgado <> | Date | Tue, 18 Oct 2011 14:07:11 +0200 | Subject | Re: [PATCH 2/5] input/cma3000_d0x: Check silicon version |
| |
Hello Jonathan
>> + if (rev != CMA3000_REV) { >> + error = -EINVAL; >> + pr_err("CMA3000 Accelerometer: Unknown Revision %x\n", rev); > warning perhaps rather than error?
IMHO it should be an error. If the revision is different, either you are in front of a unknown chip or the chip is going to behave differently and lead into an unstable system. Better be safe than sorry.
> Patch could do with a statement of why anyone would care about this. >> error = request_threaded_irq(irq, NULL, cma3000_thread_irq, >> pdata->irqflags | IRQF_ONESHOT, >> "cma3000_d0x", data);
You are right... not so useful information :). Maybe as part of a sysfs file, but definately not as as a printk
> >
-- Ricardo Ribalda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |