lkml.org 
[lkml]   [2011]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 10/10] x86, efi: EFI boot stub support

* Maarten Lankhorst <m.b.lankhorst@gmail.com> wrote:

[ a 833 lines of TOTALLY POINTLESS QUOTE ]

> > + status = low_alloc(options_size, 1, &cmdline);
> > + if (status != EFI_SUCCESS)
> > + goto fail;
> Shouldn't this be options_size + 1?
> > +
> > + s1 = (u8 *)(unsigned long)cmdline;
> > + s2 = (u16 *)options;
> > +
> > + for (i = 0; i < options_size - 1; i++)
> > + *s1++ = *s2++;
> > +
> > + *s1 = '\0';
> For this null character..
> > + }

[ another 700+ lines of TOTALLY POINTLESS QUOTE ]

It took me 3 attempts to find your comments in the 1500 lines of
email.

Please format your emails! If you quote on 20 lines of patch then you
absolutely HAVE TO cut out the remaining 1500 lines you did not
comment on ...

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-10-18 08:15    [W:0.180 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site