Messages in this thread | | | Date | Tue, 18 Oct 2011 08:09:47 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v5 10/10] x86, efi: EFI boot stub support |
| |
* Maarten Lankhorst <m.b.lankhorst@gmail.com> wrote:
[ a 833 lines of TOTALLY POINTLESS QUOTE ]
> > + status = low_alloc(options_size, 1, &cmdline); > > + if (status != EFI_SUCCESS) > > + goto fail; > Shouldn't this be options_size + 1? > > + > > + s1 = (u8 *)(unsigned long)cmdline; > > + s2 = (u16 *)options; > > + > > + for (i = 0; i < options_size - 1; i++) > > + *s1++ = *s2++; > > + > > + *s1 = '\0'; > For this null character.. > > + }
[ another 700+ lines of TOTALLY POINTLESS QUOTE ]
It took me 3 attempts to find your comments in the 1500 lines of email.
Please format your emails! If you quote on 20 lines of patch then you absolutely HAVE TO cut out the remaining 1500 lines you did not comment on ...
Thanks,
Ingo
| |