Messages in this thread | | | Date | Tue, 18 Oct 2011 11:34:11 +0200 | From | Herbert Xu <> | Subject | Re: PROBLEM: System call 'sendmsg' of process ospfd (quagga) causes kernel oops |
| |
On Tue, Oct 18, 2011 at 04:30:32AM +0200, Eric Dumazet wrote: > > If David/Herbert/Timo agree, then patch should find its way into current > kernel, then to stable trees as well.
Actually, I think we should instead fix the users of needed_headroom to not read it twice which is causing problems here.
GRE tunnels by their nature do not have a fixed value for needed_headroom. As the underlying routes change the necessary headroom may need to be adjusted due to further encapsulation such as IPsec.
Keeping it constant from tunnel creation may result in suboptimal performance due to unnecessary header reallocations.
However, until we audit the stack to see if there are further instances of double-readings such as the one causing the crash here, I'm fine with your patch making it constant.
Once we're sure that all of the double-readings are gone we can revert to a dynamic needed_headroom.
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |