lkml.org 
[lkml]   [2011]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: patch] cpusets, cgroups: disallow attaching kthreadd
From
Date
On Tue, 2011-10-18 at 11:06 +0200, Peter Zijlstra wrote:
> On Tue, 2011-10-18 at 10:47 +0200, Mike Galbraith wrote:
> > On Tue, 2011-10-18 at 10:42 +0200, Peter Zijlstra wrote:
> >
> > > Why special case these two, why not simply disallow moving kthreadd into
> > > _any_ cgroup what so ever and be done with it?
> >
> > These were the cases where it hurt, and cpusets don't have to be a
> > component of a cgroup. So we'd still need the cpuset bit.
>
> but but but,, cpusetes are a cgroup thingy?!

By golly, mount -t cpuset and the thing does say type cgroup. How 'bout
that, learn something new every day. Dinkier is better.

> > > ---
> > > diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> > > index 453100a..18eed58 100644
> > > --- a/kernel/cgroup.c
> > > +++ b/kernel/cgroup.c
> > > @@ -1824,6 +1824,9 @@ int cgroup_attach_task(struct cgroup *cgrp, struct task_struct *tsk)
> > > struct cgroup *oldcgrp;
> > > struct cgroupfs_root *root = cgrp->root;
> > >
> > > + if (tsk == kthreadd_task)
> > > + return -EINVAL;
> > > +
> > > /* Nothing to do if the task is already in that cgroup */
> > > oldcgrp = task_cgroup_from_root(tsk, root);
> > > if (cgrp == oldcgrp)
> > >
> >
> >
>




\
 
 \ /
  Last update: 2011-10-18 11:25    [W:0.096 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site