lkml.org 
[lkml]   [2011]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/10] mmc-host: move to dma_transfer_direction
On 10/14/2011 07:38 AM, Vinod Koul :
> From: Vinod Koul <vinod.koul@linux.intel.com>
>
> Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> drivers/mmc/host/atmel-mci.c | 9 ++++++---

[..]

> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -681,16 +681,19 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data)
> if (atmci_is_mci2())
> mci_writel(host, DMA, MCI_DMA_CHKSIZE(3) | MCI_DMAEN);
>
> - if (data->flags & MMC_DATA_READ)
> + if (data->flags & MMC_DATA_READ) {
> direction = DMA_FROM_DEVICE;
> - else
> + slave_dirn = DEV_TO_MEM;

It seems that the slave_dirn declaration is missing...

> + } else {
> direction = DMA_TO_DEVICE;
> + slave_dirn = MEM_TO_DEV;
> + }
>
> sglen = dma_map_sg(chan->device->dev, data->sg,
> data->sg_len, direction);
>
> desc = chan->device->device_prep_slave_sg(chan,
> - data->sg, sglen, direction,
> + data->sg, sglen, slave_dirn,
> DMA_PREP_INTERRUPT | DMA_CTRL_ACK);
> if (!desc)
> goto unmap_exit;

When fixed:

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Best regards,
--
Nicolas Ferre


\
 
 \ /
  Last update: 2011-10-17 11:59    [W:0.293 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site