Messages in this thread Patch in this message | | | From | Andrea Arcangeli <> | Subject | [PATCH 1/2] s390: gup_huge_pmd() return 0 if pte changes | Date | Mon, 17 Oct 2011 23:32:51 +0200 |
| |
s390 didn't return 0 in that case, if it's rolling back the *nr pointer it should also return zero to avoid adding pages to the array at the wrong offset.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com> --- arch/s390/mm/gup.c | 21 +++++++++++---------- 1 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/arch/s390/mm/gup.c b/arch/s390/mm/gup.c index 668dda9..da33a02 100644 --- a/arch/s390/mm/gup.c +++ b/arch/s390/mm/gup.c @@ -93,16 +93,17 @@ static inline int gup_huge_pmd(pmd_t *pmdp, pmd_t pmd, unsigned long addr, *nr -= refs; while (refs--) put_page(head); - } else { - /* - * Any tail page need their mapcount reference taken - * before we return. - */ - while (refs--) { - if (PageTail(tail)) - get_huge_page_tail(tail); - tail++; - } + return 0; + } + + /* + * Any tail page need their mapcount reference taken before we + * return. + */ + while (refs--) { + if (PageTail(tail)) + get_huge_page_tail(tail); + tail++; } return 1;
| |