Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: [PATCH] drivers, vmw_balloon.c: Determine page allocation flag can_sleep outside loop. | Date | Mon, 17 Oct 2011 11:36:06 -0700 |
| |
On Monday, October 17, 2011 11:13:47 AM Rakib Mullick wrote: > In vmballoon_reserve_page function, flags has been passed from the > callee function (vmballoon_inflate here). So, we can determine > can_sleep outside the loop. > > Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
Thanks Rakib.
Acked-by: Dmitry Torokhov <dtor@vmware.com>
> --- > > diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c > index 053d36c..6983d80 100644 > --- a/drivers/misc/vmw_balloon.c > +++ b/drivers/misc/vmw_balloon.c > @@ -412,6 +412,7 @@ static int vmballoon_reserve_page(struct vmballoon > *b, bool can_sleep) gfp_t flags; > unsigned int hv_status; > bool locked = false; > + flags = can_sleep ? VMW_PAGE_ALLOC_CANSLEEP : VMW_PAGE_ALLOC_NOSLEEP; > > do { > if (!can_sleep) > @@ -419,7 +420,6 @@ static int vmballoon_reserve_page(struct vmballoon > *b, bool can_sleep) else > STATS_INC(b->stats.sleep_alloc); > > - flags = can_sleep ? VMW_PAGE_ALLOC_CANSLEEP : VMW_PAGE_ALLOC_NOSLEEP; > page = alloc_page(flags); > if (!page) { > if (!can_sleep)
| |