lkml.org 
[lkml]   [2011]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [slabinfo PATCH] Fix off-by-one after readlink() call
From
On Fri, Oct 14, 2011 at 10:53 PM, David Rientjes <rientjes@google.com> wrote:
> On Fri, 14 Oct 2011, Thomas Jarosch wrote:
>
>> The problem is the line after the readlink() call:
>>
>> buffer[count] = '\0';
>>
>> The common technique is to reduce the buffer size by one.
>> Another fix would be to check
>>
>> "
>> if (count < 0 || count == sizeof(buffer))
>>     fatal();
>> "
>>
>> Reducing the buffer size by one is easier IMHO.
>>
>
> I think this should be used for changelog.
>
> Acked-by: David Rientjes <rientjes@google.com>

Thomas, please resend with proper changelog and with David's and
Christoph's ACKs included.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-10-17 09:19    [W:0.048 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site