Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 16 Oct 2011 08:55:17 -0700 | From | Greg KH <> | Subject | Re: [PATCH 8/8] PCI, sys: only create rescan under /sys/.../pci/devices/... for pci bridges |
| |
On Sat, Oct 15, 2011 at 10:34:03PM -0700, Yinghai Lu wrote: > On 10/15/2011 07:39 PM, Greg KH wrote: > > > > > No, we already have a way to do this, this is not acceptable, sorry. > > > > > hope this one is ok...
Nope, not at all, don't use #ifdef in .c files.
Again, we have a way to do this, built into sysfs, that can dynamically know to add or not add, attributes when they are registered with the system.
Is there some reason you want to create a new way to do this, or just ignore it by using another forbidden thing (i.e. #ifdefs)?
confused,
greg k-h
| ![\](/images/icornerr.gif) |