Messages in this thread | | | Date | Sat, 15 Oct 2011 11:28:15 +1100 (EST) | From | James Morris <> | Subject | Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1) |
| |
On Fri, 14 Oct 2011, Dmitry Kasatkin wrote:
> +MPI mpi_alloc(unsigned nlimbs) > +{ > + MPI a; > + > + a = (MPI) kmalloc(sizeof *a, GFP_KERNEL);
Generally, typedef structs are frowned upon in the kernel. I'd prefer to see this (and any others) changed to a normal type.
Also, kmalloc return values do not need to be cast, they're void *.
> +EXPORT_SYMBOL(mpi_alloc);
New interfaces should be EXPORT_SYMBOL_GPL.
-- James Morris <jmorris@namei.org>
| |