lkml.org 
[lkml]   [2011]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH v3 2/8] ASoC: da7210: Add support for DAPM
On Fri, Oct 14, 2011 at 04:31:38PM +0530, Ashish Chavan wrote:

> + /* ADCs */
> + SND_SOC_DAPM_ADC("ADC Left", "Capture", DA7210_STARTUP3, 5, 1),
> + SND_SOC_DAPM_ADC("ADC Right", "Capture", DA7210_STARTUP3, 6, 1),
> +
> + /* Output Side */
> + /* DACs */
> + SND_SOC_DAPM_DAC("DAC Left", "Playback", DA7210_STARTUP2, 5, 1),
> + SND_SOC_DAPM_DAC("DAC Right", "Playback", DA7210_STARTUP2, 6, 1),

These are also being enabled in the probe() function using completely
different registers - there the registers used are _ADC and _DAC.
What's going on there? It's good to see the stuff in the startup()
function gone but almost all of the probe() just shouldn't be there in a
properly written driver and much of it looks like stuff that DAPM should
be taking care of.


\
 
 \ /
  Last update: 2011-10-14 21:23    [W:0.041 / U:4.876 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site